This repository was archived by the owner on Apr 8, 2019. It is now read-only.
Sets errorContext error when availability check fails#7
Open
Sets errorContext error when availability check fails#7
Conversation
ata-n
reviewed
Mar 8, 2019
| func availabilityCheckDidFailWith(_ error: Error) { | ||
| tableView.isUserInteractionEnabled = true | ||
|
|
||
| errorContext?.error = BookingError.noDate |
There was a problem hiding this comment.
This is not the same error.. noDate means date has not been provided.
Error context is not necessary for this callback.
Is there a reason you added this?
Contributor
Author
There was a problem hiding this comment.
I can add a new error to describe no network connectivity
When the availability check fails, the errorContext is not updated and the screen is not reupdated.
https://www.useloom.com/share/a1434a21f9b94d198e3f1536cd8ae293
At the end of the video there is no network connectivity, when the user tries to close the date picker by clicking on the date row, the app crashes because the amount of rows available is not updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets errorContext to be .noDate to prevent the crash since we don't have any error handling for no network connectivity yet. Can be set to a more descriptive error when we do.
Issues that should be CLOSED by merge of this PR:
Related issues that should be LINKED to this PR: